Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on direct inference via nodes.FunctionDef._infer #1477

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

DanielNoord
Copy link
Collaborator

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

Fix as suggested in the issue.

Type of Changes

Type
🐛 Bug fix

Related Issue

Closes #817

@DanielNoord DanielNoord added this to the 2.12.0 milestone Mar 15, 2022
@Pierre-Sassoulas
Copy link
Member

Shouldn't this be in 2.11.1 ?

@DanielNoord
Copy link
Collaborator Author

I saw no direct reason to cherrypick as pylint doesn't depend on it and the issue hasn't gained a lot of traction in the last year, but if @eugene57 is eagerly waiting for it we can definitely include it in 2.11.1

@Pierre-Sassoulas
Copy link
Member

I was thinking crashes and bugs should be backported. But it's true that it increase the maintenance burden. Maybe only crashes ?

@DanielNoord
Copy link
Collaborator Author

I was thinking crashes and bugs should be backported. But it's true that it increase the maintenance burden. Maybe only crashes ?

Then we would need to back port this as this prevents an IndexError 😅

I think not releasing a hotfix if nobody really depends on it asap is fine. We have normal releases for "cold fixes" 😄

@Pierre-Sassoulas
Copy link
Member

Let's try to make a two bug fix release for 2.11.1 and see how much time it takes :)

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't suggest the change in interface for the changelog 2.11.1 is outside the diff. The rest LGTM.

@DanielNoord
Copy link
Collaborator Author

@Pierre-Sassoulas Do you know you can use . on the Github website to launch a web-version of VS Code to make simple changes like those? Since you're maintainer of the repo you have write access to my branches.

@Pierre-Sassoulas
Copy link
Member

Wow, this is actually impressive (and a little slow too, but less than doing adding a remote and modifying locally). Thanks for the tip !

@Pierre-Sassoulas Pierre-Sassoulas merged commit f181d7b into pylint-dev:main Mar 15, 2022
@DanielNoord
Copy link
Collaborator Author

@Pierre-Sassoulas Yeah I never used it much, but found out recently how useful it is for small changes to a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndexError in FunctionDef._infer()
2 participants