-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash on direct inference via nodes.FunctionDef._infer #1477
Conversation
Shouldn't this be in 2.11.1 ? |
I saw no direct reason to cherrypick as |
I was thinking crashes and bugs should be backported. But it's true that it increase the maintenance burden. Maybe only crashes ? |
Then we would need to back port this as this prevents an I think not releasing a hotfix if nobody really depends on it asap is fine. We have normal releases for "cold fixes" 😄 |
Let's try to make a two bug fix release for 2.11.1 and see how much time it takes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't suggest the change in interface for the changelog 2.11.1 is outside the diff. The rest LGTM.
@Pierre-Sassoulas Do you know you can use |
Wow, this is actually impressive (and a little slow too, but less than doing adding a remote and modifying locally). Thanks for the tip ! |
@Pierre-Sassoulas Yeah I never used it much, but found out recently how useful it is for small changes to a PR |
Steps
Description
Fix as suggested in the issue.
Type of Changes
Related Issue
Closes #817