Prevent special case for virtualenv's patching of distutils from catching other submodules
#1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…catching other submodules
jacobtylerwalls
added
needs-backport
Regression
pylint-tested
Pull Request Test Coverage Report for Build 2272648242
💛 - Coveralls |
|
Do you have a Windows to debug this? Seems to pass on 3.8... |
tests/unittest_regrtest.py
Outdated
| @unittest.skipUnless(HAS_NUMPY, "Needs numpy") | ||
| def test_numpy_distutils(self): | ||
| """Special handling of virtualenv's patching of distutils shouldn't interfere | ||
| with numpy.distutils""" |
There was a problem hiding this comment.
Do we need to define a specific version of numpy here ? I suppose numpy won't embark distutils forever.
There was a problem hiding this comment.
True, it's already deprecated, but won't be removed until Python 3.12 is minimum. I could add a TODO I guess.
DanielNoord
approved these changes
May 5, 2022
Pierre-Sassoulas
approved these changes
May 5, 2022
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
May 9, 2022
…catching other submodules (#1544)
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
May 9, 2022
…catching other submodules (#1544)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
Apparently, #1386 traded a false positive created by
virtualenvfor a false positive innumpy.distutils. This PR tightens the condition to pass both cases.The regression test for
virtualenvhas to be manually triggered on PyCQA. So I tested this on my fork where I could fiddle with the workflow trigger. Or I could push this branch to PyCQA; that might allow us to trigger the workflow on a branch, but not certain.Type of Changes
Related Issue
Refs pylint-dev/pylint#6497