Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify namespace package detection on Python 3.7+ #1566

Merged
merged 1 commit into from
May 15, 2022
Merged

Simplify namespace package detection on Python 3.7+ #1566

merged 1 commit into from
May 15, 2022

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented May 15, 2022 •
edited
Loading

Description

Since 3.7.2 is the min Python version, we can simplify the detection of namespace packages in PathSpecFinder.find_module().

Type of Changes

Type
✓ 🔨 Refactoring

@jacobtylerwalls jacobtylerwalls added the Maintenance Discussion or action around maintaining astroid or the dev workflow label May 15, 2022
@jacobtylerwalls jacobtylerwalls added this to the 2.12.0 milestone May 15, 2022
@jacobtylerwalls jacobtylerwalls changed the title Simplify namespace detection on Python 3.7+ Simplify namespace package detection on Python 3.7+ May 15, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2328556492

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.831%
Totals Coverage Status
Change from base Build 2328510647: 0.0%
Covered Lines: 9195
Relevant Lines: 10013
💛 - Coveralls

@jacobtylerwalls jacobtylerwalls merged commit 3ff65be into pylint-dev:main May 15, 2022
@jacobtylerwalls jacobtylerwalls deleted the namespace-cleanup branch May 15, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jacobtylerwalls @coveralls @Pierre-Sassoulas @DanielNoord