Infer modulo operations on strings #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChangeLog
Outdated
| @@ -26,6 +26,10 @@ Release date: TBA | |||
|
|
|||
| Closes #104 | |||
|
|
|||
| * Module (``%``) operations on strings are now correctly inferred. | |||
There was a problem hiding this comment.
I think we should call it %-formatting to avoid sounding like the mathematical modulo operator.
tests/unittest_inference.py
Outdated
| """, | ||
| ], | ||
| ) | ||
| def test_string_modulation_uninferable(self, format_string: str) -> None: |
There was a problem hiding this comment.
I can't use % in a function name. So percentage_formatting then?
There was a problem hiding this comment.
How about c_style_formatting old_string_formatting, printf_style_formatting or interpolation_formatting ? (I checked the python doc to see how it's called : https://docs.python.org/3/tutorial/inputoutput.html#old-string-formatting)
Pull Request Test Coverage Report for Build 2517492739
💛 - Coveralls |
Pierre-Sassoulas
approved these changes
Jun 17, 2022
astroid/inference.py
Outdated
Comment on lines
590
to
594
| const_node = nodes.const_factory(instance.value % values) | ||
| except (TypeError, KeyError): | ||
| return (util.Uninferable,) | ||
|
|
||
| return (const_node,) |
There was a problem hiding this comment.
Suggested change
| const_node = nodes.const_factory(instance.value % values) | |
| except (TypeError, KeyError): | |
| return (util.Uninferable,) | |
| return (const_node,) | |
| return (nodes.const_factory(instance.value % values),) | |
| except (TypeError, KeyError): | |
| return (util.Uninferable,) |
| for pair in other.items: | ||
| key = helpers.safe_infer(pair[0], context) | ||
| if not isinstance(key, nodes.Const): | ||
| return (util.Uninferable,) |
There was a problem hiding this comment.
This line is not covered, I guess it's not worth it ?
jacobtylerwalls
approved these changes
Jun 17, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
Closes #151
Type of Changes