Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Mixins to _base_nodes #1635

Merged
merged 3 commits into from Jun 20, 2022
Merged

Move Mixins to _base_nodes #1635

merged 3 commits into from Jun 20, 2022

Conversation

DanielNoord
Copy link
Collaborator

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

Closes #1633.

Illustrating PR for that issue.

Type of Changes

Type
✓ 🔨 Refactoring

@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining astroid or the dev workflow label Jun 19, 2022
@coveralls
Copy link

coveralls commented Jun 19, 2022 •
edited

Pull Request Test Coverage Report for Build 2527357301

  • 87 of 89 (97.75%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 92.268%
Changes Missing Coverage Covered Lines Changed/Added Lines %
astroid/nodes/_base_nodes.py 83 85 97.65%
Totals Coverage Status
Change from base Build 2527321894: 0.004%
Covered Lines: 9391
Relevant Lines: 10178
💛 - Coveralls

@DanielNoord DanielNoord marked this pull request as ready for review June 20, 2022 07:36
@DanielNoord
Copy link
Collaborator Author

@Pierre-Sassoulas I think there is agreement on the issue based on the emoji's. If you're comfortable with merging this please go ahead 😄

@Pierre-Sassoulas Pierre-Sassoulas merged commit 08fb9b5 into pylint-dev:main Jun 20, 2022
@DanielNoord DanielNoord deleted the mixins branch June 20, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move mixins.py to astroid.nodes._base_nodes
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas