Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only infer module operations on string Const nodes #1701

Merged
merged 1 commit into from
Jul 10, 2022

Conversation

DanielNoord
Copy link
Collaborator

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

Closes #1700

Type of Changes

Type
βœ“ πŸ› Bug fix

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2644730710

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 92.187%

Totals Coverage Status
Change from base Build 2644346545: 0.02%
Covered Lines: 9498
Relevant Lines: 10303

πŸ’› - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas merged commit c387a28 into pylint-dev:main Jul 10, 2022
@Pierre-Sassoulas
Copy link
Member

Should we release 2.12.2 right now ?

@jacobtylerwalls
Copy link
Member

Let me get a clean run of both primer suites locally. I should have done that yesterday.

@DanielNoord DanielNoord deleted the modulo branch July 10, 2022 13:22
@DanielNoord
Copy link
Collaborator Author

Do we need this for the upgrade to 2.12.x? If it's just a crash fix we might want to wait to see we can get 2.12.1 to work with pylint 2.15.x.

@jacobtylerwalls
Copy link
Member

jacobtylerwalls commented Jul 10, 2022

It was found in the old pylint primer and was caused in astroid 2.12.0, so it's necessary if we want all the checks to pass when upgrading to 2.12.0-1. But if you mean something like "wait and make sure this is the only blocker" i.e. want to wait for the first report from Pierre on his sys.path patching PR that's fine too.

@DanielNoord
Copy link
Collaborator Author

It was found in the old pylint primer and was caused in astroid 2.12.0, so it's necessary if we want all the checks to pass when upgrading to 2.12.0-1. But if you mean something like "wait and make sure this is the only blocker" i.e. want to wait for the first report from Pierre on his sys.path patching PR that's fine too.

Yeah. I'd say let's make sure we get all fixes necessary for the 2.12.x upgrade into 2.12.2. Nothing inherently bad with releasing a number of versions, but it only costs us more time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in modulo expression
4 participants