Decouple FunctionDef and Lambda
#2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2115 +/- ##
==========================================
- Coverage 92.74% 92.73% -0.02%
==========================================
Files 94 94
Lines 10981 11007 +26
==========================================
+ Hits 10184 10207 +23
- Misses 797 800 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Pierre-Sassoulas
requested changes
Apr 15, 2023
| """ | ||
| if "method" in self.type: | ||
| return "Method" | ||
| return "Function" |
There was a problem hiding this comment.
Should be trivial to cover (?)
Pierre-Sassoulas
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
As discussed in #2112 we really need to decouple this nodes. I think this warrants a 3.0 release for the next release. We don't need to do any of the other deprecations but this is just 100% necessary for
Mypybut will also 100% break code of users.Let me know what you think!
/CC @nickdrozd