Remove cachedproperty decorator #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
approved these changes
Apr 23, 2023
|
@DanielNoord Is |
|
@cdce8p Not sure, I was looking in the labels to find one that fit. Feels like they could use a clean up anyway, perhaps by making organisation labels and re-using them across both repo's? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2140 +/- ##
==========================================
+ Coverage 92.16% 92.23% +0.06%
==========================================
Files 94 94
Lines 10908 10889 -19
==========================================
- Hits 10053 10043 -10
+ Misses 855 846 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #2137
This PR completely removes the
cachedpropertydecorator.functools.cached_propertyis a full replacement.Also update changelog:
2.16.0->3.0.0.