Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated is_sys_guard + is_typing_guard #2153

Merged
merged 4 commits into from
Apr 25, 2023

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Apr 25, 2023

Description

Remove deprecated If.is_sys_guard and If.is_typing_guard methods.
These have been moved to pylint.

Refs #2148

@cdce8p cdce8p added Maintenance Discussion or action around maintaining astroid or the dev workflow breaking-change labels Apr 25, 2023
@cdce8p cdce8p added this to the 3.0.0a2 milestone Apr 25, 2023
@cdce8p cdce8p removed the Maintenance Discussion or action around maintaining astroid or the dev workflow label Apr 25, 2023
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@6865b2b). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2153   +/-   ##
=======================================
  Coverage        ?   92.57%           
=======================================
  Files           ?       94           
  Lines           ?    10819           
  Branches        ?        0           
=======================================
  Hits            ?    10016           
  Misses          ?      803           
  Partials        ?        0           
Flag Coverage Δ
linux 92.33% <ø> (?)
pypy 87.51% <ø> (?)
windows 92.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
astroid/nodes/node_classes.py 94.87% <ø> (ø)

ChangeLog Outdated Show resolved Hide resolved
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
@DanielNoord DanielNoord enabled auto-merge (squash) April 25, 2023 17:01
@DanielNoord DanielNoord merged commit 08ed413 into pylint-dev:main Apr 25, 2023
@cdce8p cdce8p deleted the remove-sys-typing-guard branch April 25, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants