Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress exception context describing a cache miss #2205

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Jun 7, 2023

Type of Changes

Type
:Refactor

Description

Having the KeyError from a cache miss in a traceback about an AstroidError is a red herring that can confuse reporters and maintainers. Suppress it.

Refs pylint-dev/pylint-django#399

No changelog

@jacobtylerwalls jacobtylerwalls added Minor 💅 Polishing astroid is always nice Maintenance Discussion or action around maintaining astroid or the dev workflow labels Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #2205 (2a643b3) into main (bd78ab0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2205   +/-   ##
=======================================
  Coverage   92.68%   92.68%           
=======================================
  Files          94       94           
  Lines       10818    10820    +2     
=======================================
+ Hits        10027    10029    +2     
  Misses        791      791           
Flag Coverage Δ
linux 92.44% <100.00%> (+<0.01%) ⬆️
pypy 87.65% <100.00%> (+<0.01%) ⬆️
windows 92.28% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
astroid/inference_tip.py 97.82% <100.00%> (+0.09%) ⬆️

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense !

@jacobtylerwalls jacobtylerwalls merged commit bb0573d into pylint-dev:main Jun 7, 2023
20 checks passed
@jacobtylerwalls jacobtylerwalls deleted the suppress-context branch June 7, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow Minor 💅 Polishing astroid is always nice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants