Improve performance of _get_zipimporters #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_get_zipimporters can call isinstance millions of times when running pylint's import-error checker on a codebase like yt-dlp. Checking for None first avoids the overhead of invoking isinstance. Closes pylint-dev/pylint#9607.
|
(pypy 3.8 and 3.10 are flaky, nothing to do on your end) |
DanielNoord
approved these changes
May 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2428 +/- ##
==========================================
- Coverage 92.78% 92.59% -0.19%
==========================================
Files 94 94
Lines 11098 11098
==========================================
- Hits 10297 10276 -21
- Misses 801 822 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
_get_zipimporterscan callisinstancemillions of times when running pylint'simport-errorchecker on a codebase like yt-dlp.Checking for
Nonefirst avoids the overhead of invokingisinstance.Closes pylint-dev/pylint#9607.
Performance
I ran pylint with just the
import-errorchecker on the yt-dlp codebase. With pylint 3.1.0 and astroid 3.1.0, linting takes ~38.2 seconds. With the fix applied, linting takes ~36.3 seconds.Type of Changes