Inferring property fields in a class context when metaclass is present #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelfin
force-pushed
the
fix/940-metaclass-subclass-property
branch
2 times, most recently
from
643d548
to
89fac51
Compare
nelfin
force-pushed
the
fix/940-metaclass-subclass-property
branch
from
da5f55a
to
35d2941
Compare
nelfin
force-pushed
the
fix/940-metaclass-subclass-property
branch
from
35d2941
to
b389805
Compare
4 tasks
nelfin
force-pushed
the
fix/940-metaclass-subclass-property
branch
from
b389805
to
39d359d
Compare
cdce8p
requested changes
May 13, 2021
nelfin
force-pushed
the
fix/940-metaclass-subclass-property
branch
from
5dcd0ed
to
f6f43ab
Compare
Ref pylint-dev#940. If we are accessing an attribute and it is found on type(A).__dict__ *and* it is a data descriptor, then we resolve that descriptor. For the case of inferring a property which is accessed as a class attribute, this equates to the property being defined on the metaclass (which may be anywhere in the class hierarchy).
nelfin
force-pushed
the
fix/940-metaclass-subclass-property
branch
from
f6f43ab
to
8afdc7b
Compare
cdce8p
reviewed
May 14, 2021
Ref pylint-dev/pylint#3535. Ref pylint-dev/pylint#4358. This updates the namedtuple/enum brain to add a dictionary for __members__
nelfin
force-pushed
the
fix/940-metaclass-subclass-property
branch
from
8afdc7b
to
103f440
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
If we are accessing an attribute and it is found on
type(A).__dict__and it is a data descriptor, then we resolve thatdescriptor. For the case of inferring a property which is accessed as a
class attribute, this equates to the property being defined on the
metaclass (which may be anywhere in the class hierarchy).
Type of Changes
Related Issue
Closes #940