Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing settings path using argument instead of env #286

Open
Goldziher opened this issue Aug 15, 2020 · 0 comments
Open

Allow passing settings path using argument instead of env #286

Goldziher opened this issue Aug 15, 2020 · 0 comments

Comments

@Goldziher
Copy link

Hi there,

There is a problem using this plugin together with Pre-Commit because its impossible to inject env variables in the Pre-Commit hooks. I'd like to suggest / request that you guys add an optional argument for the path of settings.py for a given project, or use another scheme to get it.

Thanks
carlio added a commit that referenced this issue Aug 24, 2020
@carlio
Moved the Django foreignkey field into a separate checker to enable t…
36fc49f 
…he `open()` pre-configuration. This allows the django settings module to be set from a command-line option or .pylintrc option as well as an environment variable (refs #286). This commit also uses default Django settings if none are specified, raising an error to the user to inform them that it is better to set it explicitly, but avoiding the need to raise a Fatal or RuntimeError if Django is not configured (refs #277 and #243)
@carlio carlio mentioned this issue Aug 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Goldziher