Refactor - Move _rest_format_section in message_handler_mix_in.py

Following review see : #2654 (comment)
pylint-dev · Mar 8, 2019 · 3de592c · 3de592c
1 parent ca2ba2e
commit 3de592c
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 20 deletions.
diff --git a/pylint/utils/message_handler_mix_in.py b/pylint/utils/message_handler_mix_in.py
@@ -22,13 +22,33 @@
 from pylint.utils.message import Message
 from pylint.utils.utils import (
     WarningScope,
-    _rest_format_section,
+    _format_option_value,
     build_message_def,
     category_id,
     get_module_and_frameid,
+    normalize_text,
 )
 
 
+def _rest_format_section(stream, section, options, doc=None):
+    """format an options section using as ReST formatted output"""
+    if section:
+        print("%s\n%s" % (section, "'" * len(section)), file=stream)
+    if doc:
+        print(normalize_text(doc, line_len=79, indent=""), file=stream)
+        print(file=stream)
+    for optname, optdict, value in options:
+        help_opt = optdict.get("help")
+        print(":%s:" % optname, file=stream)
+        if help_opt:
+            help_opt = normalize_text(help_opt, line_len=79, indent="  ")
+            print(help_opt, file=stream)
+        if value:
+            value = str(_format_option_value(optdict, value))
+            print(file=stream)
+            print("  Default: ``%s``" % value.replace("`` ", "```` ``"), file=stream)
+
+
 class MessagesHandlerMixIn:
     """a mix-in class containing all the messages related methods for the main
     lint class

diff --git a/pylint/utils/utils.py b/pylint/utils/utils.py
@@ -374,22 +374,3 @@ def _ini_format(stream, options):
 
 
 format_section = _ini_format_section
-
-
-def _rest_format_section(stream, section, options, doc=None):
-    """format an options section using as ReST formatted output"""
-    if section:
-        print("%s\n%s" % (section, "'" * len(section)), file=stream)
-    if doc:
-        print(normalize_text(doc, line_len=79, indent=""), file=stream)
-        print(file=stream)
-    for optname, optdict, value in options:
-        help_opt = optdict.get("help")
-        print(":%s:" % optname, file=stream)
-        if help_opt:
-            help_opt = normalize_text(help_opt, line_len=79, indent="  ")
-            print(help_opt, file=stream)
-        if value:
-            value = str(_format_option_value(optdict, value))
-            print(file=stream)
-            print("  Default: ``%s``" % value.replace("`` ", "```` ``"), file=stream)