Skip to content

Commit

Permalink
Small refactor
Browse files Browse the repository at this point in the history
  • Loading branch information
DanielNoord committed Sep 2, 2022
1 parent 68ea2d5 commit 9da9b5d
Showing 1 changed file with 11 additions and 6 deletions.
17 changes: 11 additions & 6 deletions pylint/lint/pylinter.py
Original file line number Diff line number Diff line change
Expand Up @@ -660,9 +660,7 @@ def check(self, files_or_modules: Sequence[str] | str) -> None:
# 3) Get all FileItems
with fix_import_path(files_or_modules):
if self.config.from_stdin:
fileitems = iter(
(self._get_file_descr_from_stdin(files_or_modules[0]),)
)
fileitems = self._get_file_descr_from_stdin(files_or_modules[0])
data: str | None = _read_stdin()
else:
fileitems = self._iterate_file_descrs(files_or_modules)
Expand Down Expand Up @@ -817,14 +815,21 @@ def _check_file(
for msgid, line, args in spurious_messages:
self.add_message(msgid, line, None, args)

@staticmethod
def _get_file_descr_from_stdin(filepath: str) -> FileItem:
def _get_file_descr_from_stdin(self, filepath: str) -> Iterator[FileItem]:
"""Return file description (tuple of module name, file path, base name) from
given file path.
This method is used for creating suitable file description for _check_files when the
source is standard input.
"""
if _is_ignored_file(
filepath,
self.config.ignore,
self.config.ignore_patterns,
self.config.ignore_paths,
):
return

try:
# Note that this function does not really perform an
# __import__ but may raise an ImportError exception, which
Expand All @@ -833,7 +838,7 @@ def _get_file_descr_from_stdin(filepath: str) -> FileItem:
except ImportError:
modname = os.path.splitext(os.path.basename(filepath))[0]

return FileItem(modname, filepath, filepath)
yield FileItem(modname, filepath, filepath)

def _iterate_file_descrs(
self, files_or_modules: Sequence[str]
Expand Down

0 comments on commit 9da9b5d

Please sign in to comment.