Skip to content

Commit

Permalink
Handle more unnecessary-lambda cases when dealing with additional k…
Browse files Browse the repository at this point in the history
…wargs in wrapped calls

Close #2845
  • Loading branch information
PCManticore committed Apr 3, 2019
1 parent b4721fb commit c8db761
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 2 deletions.
4 changes: 4 additions & 0 deletions ChangeLog
Expand Up @@ -7,6 +7,10 @@ What's New in Pylint 2.4.0?

Release date: TBA

* Handle more `unnecessary-lambda` cases when dealing with additional kwargs in wrapped calls

Close #2845

* Better postponed evaluation of annotations handling

Close #2847
Expand Down
14 changes: 12 additions & 2 deletions pylint/checkers/base.py
Expand Up @@ -47,6 +47,7 @@
import astroid
import astroid.bases
import astroid.scoped_nodes
from astroid.arguments import CallSite

import pylint.utils as lint_utils
from pylint import checkers, exceptions, interfaces
Expand Down Expand Up @@ -1174,20 +1175,29 @@ def visit_lambda(self, node):
# return something else (but we don't check that, yet).
return

call_site = CallSite.from_call(call)
ordinary_args = list(node.args.args)
new_call_args = list(self._filter_vararg(node, call.args))
if node.args.kwarg:
if self._has_variadic_argument(call.kwargs, node.args.kwarg):
return
elif call.kwargs or call.keywords:
return

if node.args.vararg:
if self._has_variadic_argument(call.starargs, node.args.vararg):
return
elif call.starargs:
return

if call.keywords:
# Look for additional keyword arguments that are not part
# of the lambda's signature
lambda_kwargs = {keyword.name for keyword in node.args.defaults}
if len(lambda_kwargs) != len(call_site.keyword_arguments):
# Different lengths, so probably not identical
return
if set(call_site.keyword_arguments).difference(lambda_kwargs):
return

# The "ordinary" arguments must be in a correspondence such that:
# ordinary_args[i].name == call.args[i].name.
if len(ordinary_args) != len(new_call_args):
Expand Down
2 changes: 2 additions & 0 deletions pylint/test/functional/unnecessary_lambda.py
Expand Up @@ -49,3 +49,5 @@

# Don't warn about this.
_ = lambda: code().analysis()

_ = lambda **kwargs: dict(bar=42, **kwargs)

0 comments on commit c8db761

Please sign in to comment.