Add version-specific functional tests for bad_reversed_sequence

pylint-dev · Nov 30, 2020 · d095b19 · d095b19
1 parent 22e805e
commit d095b19
Show file tree

Hide file tree

Showing 8 changed files with 20 additions and 9 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -1,6 +1,9 @@
 ------------------
 Pylint's ChangeLog
 ------------------
+* Only emit `bad-reversed-sequence` on dictionaries if below py3.8
+
+  Closes #3940
 
 * Handle class decorators applied to function.
 

diff --git a/tests/functional/b/bad_reversed_sequence.py b/tests/functional/b/bad_reversed_sequence.py
@@ -44,7 +44,6 @@ def test(path):
     seq = reversed([1, 2, 3])
     seq = reversed((1, 2, 3))
     seq = reversed(set()) # [bad-reversed-sequence]
-    seq = reversed({'a': 1, 'b': 2}) # [bad-reversed-sequence]
     seq = reversed(iter([1, 2, 3])) # [bad-reversed-sequence]
     seq = reversed(GoodReversed())
     seq = reversed(SecondGoodReversed())

diff --git a/tests/functional/b/bad_reversed_sequence.txt b/tests/functional/b/bad_reversed_sequence.txt
@@ -1,8 +1,10 @@
-bad-reversed-sequence:43:test:The first reversed() argument is not a sequence
-bad-reversed-sequence:46:test:The first reversed() argument is not a sequence
-bad-reversed-sequence:47:test:The first reversed() argument is not a sequence
-bad-reversed-sequence:48:test:The first reversed() argument is not a sequence
-bad-reversed-sequence:51:test:The first reversed() argument is not a sequence
-bad-reversed-sequence:52:test:The first reversed() argument is not a sequence
-bad-reversed-sequence:54:test:The first reversed() argument is not a sequence
-bad-reversed-sequence:55:test:The first reversed() argument is not a sequence
+bad-reversed-sequence:43:test:The first reversed() argument is not a sequence
+bad-reversed-sequence:46:test:The first reversed() argument is not a sequence
+bad-reversed-sequence:47:test:The first reversed() argument is not a sequence
+bad-reversed-sequence:48:test:The first reversed() argument is not a sequence
+bad-reversed-sequence:50:test:The first reversed() argument is not a sequence
+bad-reversed-sequence:51:test:The first reversed() argument is not a sequence
+bad-reversed-sequence:52:test:The first reversed() argument is not a sequence
+bad-reversed-sequence:53:test:The first reversed() argument is not a sequence
+bad-reversed-sequence:54:test:The first reversed() argument is not a sequence
+bad-reversed-sequence:55:test:The first reversed() argument is not a sequence
diff --git a/tests/functional/b/bad_reversed_sequence_py37.py b/tests/functional/b/bad_reversed_sequence_py37.py
@@ -0,0 +1,2 @@
+""" Dictionaries are reversible starting on python 3.8"""
+reversed({'a': 1, 'b': 2}) # [bad-reversed-sequence]
diff --git a/tests/functional/b/bad_reversed_sequence_py37.rc b/tests/functional/b/bad_reversed_sequence_py37.rc
@@ -0,0 +1,2 @@
+[testoptions]
+max_pyver=3.8
diff --git a/tests/functional/b/bad_reversed_sequence_py37.txt b/tests/functional/b/bad_reversed_sequence_py37.txt
@@ -0,0 +1 @@
+bad-reversed-sequence:2::The first reversed() argument is not a sequence
diff --git a/tests/functional/b/bad_reversed_sequence_py38.py b/tests/functional/b/bad_reversed_sequence_py38.py
@@ -0,0 +1,2 @@
+""" Dictionaries are reversible starting on python 3.8"""
+reversed({'a': 1, 'b': 2})
diff --git a/tests/functional/b/bad_reversed_sequence_py38.txt b/tests/functional/b/bad_reversed_sequence_py38.txt