Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad-continuation is still present in 2.5.3 #3761

Closed
silpheel opened this issue Jul 31, 2020 · 5 comments
Closed

bad-continuation is still present in 2.5.3 #3761

silpheel opened this issue Jul 31, 2020 · 5 comments
Assignees

Comments

@silpheel
Copy link

Steps to reproduce

  1. Prepare a python file with indentation in the signature as described in Current behavior.
  2. run pylint
  3. bad-continuation is reported

Current behavior

> cat badcont.py
def test(
    a, b
):
    print(a, b)

> pylint badcont.py
************* Module badcont
badcont.py:2:0: C0330: Wrong hanging indentation before block (add 4 spaces).
    a, b
    ^   | (bad-continuation)
badcont.py:1:0: C0114: Missing module docstring (missing-module-docstring)
badcont.py:1:0: C0116: Missing function or method docstring (missing-function-docstring)

---------------------------------------------------------------------
Your code has been rated at -5.00/10 

Expected behavior

bad-continuation should have been removed since 2.5.1 as per #3571

pylint --version output

pylint 2.5.3
astroid 2.4.2
Python 3.6.11 (default, Jul 17 2020, 14:57:20)
[GCC 4.2.1 Compatible Apple LLVM 11.0.3 (clang-1103.0.32.29)]

@Pierre-Sassoulas Pierre-Sassoulas self-assigned this Jul 31, 2020
@danrneal
Copy link
Contributor

danrneal commented Aug 4, 2020

For some reason, the file downloaded from pypi with pip does not match the master branch on github. All the bad-continuation stuff is still included in my local copy.

@danrneal
Copy link
Contributor

danrneal commented Aug 4, 2020

Actually the problem is with the tag for 2.5.3 in git is exactly the same as 2.5.2 which is exactly the same as 2.5.1 which is exactly the same as 2.5.0. Essentially it's as if no work after 2.5.0 has actually been released.

EDIT: Tags are fine, but releases are being done off of 2.5 branch and a lot of commits have been left out of that branch compared to master, including the bad-continuation commits

@danrneal
Copy link
Contributor

danrneal commented Aug 4, 2020

@PCManticore It looks as if you are doing the tagging, you may want to take a look at this. Sorry for the multiple messages/pings.

@dbaty
Copy link
Contributor

dbaty commented Sep 6, 2020

pylint 2.6.0 has been released since you opened this issue. I cannot reproduce the bug with this version. (Note that I needed to add --enable=bad-continuation to reproduce with pylint 2.5.*)

I don't think that versions 2.5.x should be replaced on PyPI. So we should probably close this,shall we?

@Pierre-Sassoulas
Copy link
Member

Good point @dbaty, thank you for trying to reproduce !

nmdefries added a commit to cmu-delphi/covidcast-indicators that referenced this issue Mar 30, 2021
Remove C0330, which has been removed from [pylint](pylint-dev/pylint#3761). Including an undefined error tag causes subsequent tags to not be recognized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants