Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration to pyproject.toml #4193

Closed
Pierre-Sassoulas opened this issue Mar 5, 2021 · 2 comments · Fixed by #7076
Closed

Migration to pyproject.toml #4193

Pierre-Sassoulas opened this issue Mar 5, 2021 · 2 comments · Fixed by #7076
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Minor 💅 Polishing pylint is always nice
Milestone
2.15.0

Comments

@Pierre-Sassoulas
Copy link
Member

The packaging of pylint is a little dated, old files are kept and do not serve any purpose anymore (debian packaging is done elsewhere). The information are in multiple places and we still have a compatibility with distutils when it has been replaced by setuptools a long time ago. This might benefit from a little poetry 😉

Additional context

#3686 (comment)
@Pierre-Sassoulas Pierre-Sassoulas mentioned this issue Mar 5, 2021
Closed
@Pierre-Sassoulas Pierre-Sassoulas self-assigned this Mar 26, 2021
This was referenced Apr 4, 2021
Merged
Merged
@Pierre-Sassoulas
Copy link
Member Author

We migrated to setuptools and cleaned a lot of thing, I think this is good enough for now.

@Pierre-Sassoulas Pierre-Sassoulas added Minor 💅 Polishing pylint is always nice Maintenance Discussion or action around maintaining pylint or the dev workflow and removed Enhancement ✨ Improvement to a component labels Apr 5, 2021
@Pierre-Sassoulas Pierre-Sassoulas changed the title Packaging clean-up, migration to pyproject.toml Migration to pyproject.toml Apr 5, 2021
@cdce8p
Copy link
Member

cdce8p commented Apr 5, 2021

We migrated to setuptools and cleaned a lot of thing, I think this is good enough for now.

I fully agree. setuptools seem to work fine. Using poetry would mean that current devs need to change their requirements / environment handling and might alienate some. Without a clear advantage, I wouldn't recommend changing.

@Pierre-Sassoulas Pierre-Sassoulas removed their assignment Apr 5, 2021
@cdce8p cdce8p mentioned this issue Jun 27, 2022
Merged
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.15.0 milestone Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Minor 💅 Polishing pylint is always nice
Projects
None yet
Milestone
2.15.0
Development

Successfully merging a pull request may close this issue.

Improve packaging [PEP 517 + 621] cdce8p/pylint
2 participants
@Pierre-Sassoulas @cdce8p