Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused legacy build file #4295

Merged
merged 4 commits into from
Apr 4, 2021
Merged

Remove unused legacy build file #4295

merged 4 commits into from
Apr 4, 2021

Conversation

Pierre-Sassoulas
Copy link
Member

Description

First step before merging #4294

Type of Changes

Type
✓ 🔨 Refactoring

Related Issue

#4193

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Apr 4, 2021
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.8.0 milestone Apr 4, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.611% when pulling a18e8ba on Pierre-Sassoulas:remove-unused-build-file into a69755d on PyCQA:master.

@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request Apr 4, 2021
Merged
@cdce8p
Copy link
Member

cdce8p commented Apr 4, 2021

I would be fine with removing those. Just don't know if anybody would need them. At least for packaging to PYPI, they aren't used.

@Pierre-Sassoulas
Copy link
Member Author

The man files and DEPEND were used but they were so outdated that we might as well not have them. pylint --help can replace the man pages I think...

@cdce8p
Copy link
Member

cdce8p commented Apr 4, 2021

The man files and DEPEND were used but they were so outdated that we might as well not have them. pylint --help can replace the man pages I think...

I agree. At least I haven't used them. In case I do want to look up something, I use the online version of the docs.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 85ef625 into pylint-dev:master Apr 4, 2021
@Pierre-Sassoulas Pierre-Sassoulas deleted the remove-unused-build-file branch April 4, 2021 20:47
@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 2.9.0, 2.8.3 May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdce8p cdce8p Awaiting requested review from cdce8p

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pierre-Sassoulas @coveralls @cdce8p