Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylint/2.15.8: python/3.11.1: debian: tests/test_check_parallel.py tests fail/hang indefinitely #7916

Closed
sandrotosi opened this issue Dec 10, 2022 · 2 comments · Fixed by #7918
Labels
Milestone

Comments

@sandrotosi
Copy link
Contributor

Bug description

Running tests with python3.11, makes some tests/test_check_parallel.py either fail or hang indefinitely:

I: pybuild base:240: cd /build/pylint-2.15.8/.pybuild/cpython3_3.11/build; python3.11 -m pytest -vvvv -k 'not test_pkginfo and not test_do_not_import_files_from_local_directory and not test_import_plugin_from_local_directory_if_pythonpath_cwd and not test_can_list_directo
ries_without_dunder_init and not test_fail_on_exit_code and not test__test_environ_pythonpath_no_arg'
============================= test session starts ==============================
platform linux -- Python 3.11.1, pytest-7.1.2, pluggy-1.0.0+repack -- /usr/bin/python3.11
cachedir: .pytest_cache
benchmark: 3.2.2 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
rootdir: /build/pylint-2.15.8, configfile: setup.cfg
plugins: benchmark-3.2.2
collecting ... collected 2057 items / 15 deselected / 2042 selected

tests/test_check_parallel.py::TestCheckParallelFramework::test_worker_initialize FAILED [  0%]
tests/test_check_parallel.py::TestCheckParallelFramework::test_worker_initialize_pickling PASSED [  0%]
tests/test_check_parallel.py::TestCheckParallelFramework::test_worker_check_single_file_uninitialised PASSED [  0%]
tests/test_check_parallel.py::TestCheckParallelFramework::test_worker_check_single_file_no_checkers FAILED [  0%]
tests/test_check_parallel.py::TestCheckParallelFramework::test_linter_with_unpickleable_plugins_is_pickleable PASSED [  0%]
tests/test_check_parallel.py::TestCheckParallelFramework::test_worker_check_sequential_checker FAILED [  0%]
tests/test_check_parallel.py::TestCheckParallel::test_sequential_checkers_work Terminated

the last had to be killed

the same code, ran with python 3.10 works fine:

I: pybuild base:240: cd /build/pylint-2.15.8/.pybuild/cpython3_3.10/build; python3.10 -m pytest -vvvv -k 'not test_pkginfo and not test_do_not_import_files_from_local_directory and not test_import_plugin_from_local_directory_if_pythonpath_cwd and not test_can_list_directo
ries_without_dunder_init and not test_fail_on_exit_code and not test__test_environ_pythonpath_no_arg'
============================= test session starts ==============================
platform linux -- Python 3.10.9, pytest-7.1.2, pluggy-1.0.0+repack -- /usr/bin/python3.10
cachedir: .pytest_cache
benchmark: 3.2.2 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
rootdir: /build/pylint-2.15.8, configfile: setup.cfg
plugins: benchmark-3.2.2
collecting ... collected 2056 items / 15 deselected / 2041 selected

tests/test_check_parallel.py::TestCheckParallelFramework::test_worker_initialize PASSED [  0%]
tests/test_check_parallel.py::TestCheckParallelFramework::test_worker_initialize_pickling PASSED [  0%]
tests/test_check_parallel.py::TestCheckParallelFramework::test_worker_check_single_file_uninitialised PASSED [  0%]
tests/test_check_parallel.py::TestCheckParallelFramework::test_worker_check_single_file_no_checkers PASSED [  0%]
tests/test_check_parallel.py::TestCheckParallelFramework::test_linter_with_unpickleable_plugins_is_pickleable PASSED [  0%]
tests/test_check_parallel.py::TestCheckParallelFramework::test_worker_check_sequential_checker PASSED [  0%]
tests/test_check_parallel.py::TestCheckParallel::test_sequential_checkers_work PASSED [  0%]
tests/test_check_parallel.py::TestCheckParallel::test_invoke_single_job PASSED [  0%]
tests/test_check_parallel.py::TestCheckParallel::test_compare_workers_to_single_proc[1-2-1] PASSED [  0%]
tests/test_check_parallel.py::TestCheckParallel::test_compare_workers_to_single_proc[1-2-2] PASSED [  0%]
...

this is running in debian unstable, with astroid/2.12.13

Configuration

No response

Command used

pytest command and switches reported above

Pylint output

n/a

Expected behavior

unittests to work

Pylint version

pylint 2.15.8
astroid 2.12.13
python 3.11.1

OS / Environment

Debian unstable

Additional dependencies

No response

@sandrotosi sandrotosi added the Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling label Dec 10, 2022
@Pierre-Sassoulas Pierre-Sassoulas added Blocker 🙅 Blocks the next release Bug 🪲 Needs investigation 🔬 A bug or crash where it's not immediately obvious what is happenning multiprocessing labels Dec 10, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.16.0 milestone Dec 10, 2022
@DanielNoord
Copy link
Collaborator

I think we saw this issue as well. Have you updated dill as well?

@Pierre-Sassoulas Pierre-Sassoulas removed the Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling label Dec 10, 2022
@sandrotosi
Copy link
Contributor Author

I think we saw this issue as well. Have you updated dill as well?

I didnt, since i didnt see any update to pyproject.toml suggesting i should. i tried with dill/0.3.6 and tests seem to work, so i've opened #7918 to address it

@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 2.16.0, 2.15.9 Dec 11, 2022
@Pierre-Sassoulas Pierre-Sassoulas removed the Needs investigation 🔬 A bug or crash where it's not immediately obvious what is happenning label Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants