Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylint/2.17.4: doc/data/messages/t/too-many-lines/good/__init__.py has windows line end #8883

Closed
sandrotosi opened this issue Jul 26, 2023 · 5 comments · Fixed by #8884
Closed

Comments

@sandrotosi
Copy link
Contributor

Bug description

It appears as if doc/data/messages/t/too-many-lines/good/__init__.py as windows line ends:

$ cat -vte pylint-2.17.4/doc/data/messages/t/too-many-lines/good/__init__.py
__all__ = ["is_palindrome", "main"]^M$
^M$
from is_palindrome import is_palindrome^M$
from main import main^M$

this is causing some issues in Debian, where importing the 2.17.4 tarball into our git repo will cause the windows line end to be converted to unix, and then our tools complain the code in the packaging repo is different than upstream 🤷

would you be able to convert those line ends to unix? dos2unix should do the trick

Configuration

No response

Command used

n/a

Pylint output

n/a

Expected behavior

n/a

Pylint version

n/a

OS / Environment

No response

Additional dependencies

No response

@sandrotosi sandrotosi added the Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling label Jul 26, 2023
@Pierre-Sassoulas Pierre-Sassoulas added Documentation 📗 Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer and removed Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling labels Jul 26, 2023
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.17.5 milestone Jul 26, 2023
@Pierre-Sassoulas
Copy link
Member

Sure, we're trying to have windows line ending in our tests some of the time, but removing from the doc is fine.

@Pierre-Sassoulas
Copy link
Member

We're going to release 2.17.5 shortly, it's long overdue anyway :)

Pierre-Sassoulas pushed a commit that referenced this issue Jul 26, 2023
Closes #8883

(cherry picked from commit a57dd01)

Co-authored-by: Mark Byrne <31762852+mbyrnepr2@users.noreply.github.com>
@Pierre-Sassoulas Pierre-Sassoulas removed the Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer label Jul 26, 2023
@sandrotosi
Copy link
Contributor Author

Sure, we're trying to have windows line ending in our tests some of the time, but removing from the doc is fine.

oh are there already tests files with windows line-ending? i would have expected to generated the same error i saw for that doc file, but it's not the case

@Pierre-Sassoulas
Copy link
Member

Probably others too: https://github.com/pylint-dev/pylint/blob/main/.gitattributes. In particular doc/data/messages/u/unexpected-line-ending-format/bad.py this one being in the doc too (by design this is what we're checking for).

@sandrotosi
Copy link
Contributor Author

oh so maybe being part of .gitattributes make the other files fine for the debian packaging perspective, thanks!

Pierre-Sassoulas added a commit to Pierre-Sassoulas/pylint that referenced this issue Aug 9, 2023
Pierre-Sassoulas added a commit to Pierre-Sassoulas/pylint that referenced this issue Aug 9, 2023
Pierre-Sassoulas added a commit that referenced this issue Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants