Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new checker (unnecessary-comprehension) (close #2905) #2999

Merged
merged 2 commits into from
Jul 16, 2019

Conversation

pheanex
Copy link
Contributor

@pheanex pheanex commented Jul 10, 2019

Steps

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature or an important bug fix, add a What's New entry in doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Description

Add a new checker "unnecessary-comprehension" (See #2905)

Type of Changes

Type
✨ New feature

Related Issue

Closes #2905

PHeanEX added 2 commits July 10, 2019 19:41
I mean its ugly now, but if you want it like that: Here you go
@coveralls
Copy link

coveralls commented Jul 12, 2019

Coverage Status

Coverage increased (+0.01%) to 89.889% when pulling c354006 on pheanex:feature-2905 into f5cd858 on PyCQA:master.

@PCManticore PCManticore merged commit 0a6b0c5 into pylint-dev:master Jul 16, 2019
@PCManticore
Copy link
Contributor

This was a great PR to review @pheanex ! Thank you.

@pheanex pheanex deleted the feature-2905 branch July 16, 2019 15:01
@pheanex pheanex restored the feature-2905 branch July 16, 2019 15:02
@pheanex pheanex deleted the feature-2905 branch July 16, 2019 15:02
@pheanex pheanex restored the feature-2905 branch July 16, 2019 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Add a [unnecessary-comprehension]-checker
3 participants