Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wip - Puts issue #4118 under test - test min similarities #4179

Closed

Commits on Mar 22, 2021

  1. Puts issue pylint-dev#4118 under test

    Taken in isolation, this commit may appear heavy-weight. The intent here
    is to have a linter run and retain all state information about that run
    so we can inspect what happened.
    
    What this commit shows is that the checkers the linter knows about have
    the right config, but still multi-job [MJ] runs are incorrect.
        see: assert checker.config.min_similarity_lines == min_similarity_lines
    
    I think the MJ failiures are because SimilarChecker.reduce_map_data()
    constructs a new SimilarChecker and then the linter doesn't call
    set_option().
    
    The process by which the set_option() calls are made in the normal run
    is opaque to me, but perhaps someone else has a better idea(?).
    doublethefish committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    f9333f9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    87266fc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    49d6750 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2021

  1. Update tests/test_config.py

    Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
    doublethefish and Pierre-Sassoulas committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    b15c5b6 View commit details
    Browse the repository at this point in the history