Add regression tests of instance attribute inference on builtins.object #4348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelfin
force-pushed
the
fix/astroid-945-regression-tests
branch
from
237e4e5
to
f611af2
Compare
cdce8p
added
the
Needs astroid update
|
(Now that pylint-dev/astroid#946 has landed, these tests should pass on re-run) |
|
It's possible that we need a new release of astroid first. |
Yeah, although I would still wait a bit with that. For sure before the next |
Merged
|
This can be rebased on master to get astroid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
doc/whatsnew/<current release.rst>.Description
Regression tests for various behaviours fixed by pylint-dev/astroid#946.
Ref #3595, #4221, #3970. Depends pylint-dev/astroid#946.
Type of Changes
Related Issue
Closes #3595
Closes #4221
Closes #3970
Closes #4232