Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle floats when parsing pyproject.toml (#4518) #4520

Merged
merged 2 commits into from
May 29, 2021
Merged

Handle floats when parsing pyproject.toml (#4518) #4520

merged 2 commits into from
May 29, 2021

Conversation

siehar
Copy link
Contributor

@siehar siehar commented May 28, 2021

Steps

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

Cast floats to string so ConfigParser can handle them, just like ints.

Type of Changes

Type
✓ 🐛 Bug fix

Related Issue

Closes #4518

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.847% when pulling 82ccb86 on siehar:pyproject-toml-float-fix into 6d449f9 on PyCQA:master.

Pierre-Sassoulas
Pierre-Sassoulas approved these changes May 29, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, and congratulation for your first contribution ;)

@Pierre-Sassoulas Pierre-Sassoulas merged commit 4f8ab69 into pylint-dev:master May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when using floats in pyproject.toml
3 participants
@siehar @coveralls @Pierre-Sassoulas