Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases to unused-variable message #4540

Merged
merged 5 commits into from
Jun 2, 2021
Merged

Add test cases to unused-variable message #4540

merged 5 commits into from
Jun 2, 2021

Conversation

ksaketou
Copy link
Contributor

@ksaketou ksaketou commented Jun 2, 2021

Steps

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature or an important bug fix, add a What's New entry in
    doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Description

This pull request adds some test cases to the unused-variable message related to nested exceptions.
The current errors emitted for these cases are not complete and that is due to the bug of #4391.

Type of Changes

Type
✓ 🔨 Refactoring

Related Issue

#4391

@coveralls
Copy link

coveralls commented Jun 2, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.007%) to 91.861% when pulling c062223 on ksaketou:unused-tests into 70beb53 on PyCQA:master.

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Jun 2, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the testing work ! :)

ChangeLog Outdated Show resolved Hide resolved
tests/functional/u/unused/unused_variable.py Outdated Show resolved Hide resolved
tests/functional/u/unused/unused_variable.py Show resolved Hide resolved
tests/functional/u/unused/unused_variable.py Show resolved Hide resolved
tests/functional/u/unused/unused_variable.py Show resolved Hide resolved
@ksaketou
Copy link
Contributor Author

ksaketou commented Jun 2, 2021

No problem! I will fix the expected lines on the .txt now since they changed with your additions

@Pierre-Sassoulas Pierre-Sassoulas merged commit 6dae5e9 into pylint-dev:master Jun 2, 2021
@ksaketou ksaketou deleted the unused-tests branch September 2, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ksaketou @coveralls @Pierre-Sassoulas