Fix false-positives of unnecessary-dict-index-lookup and consider-using-dict-items

[yushao2]

Steps

• Add yourself to CONTRIBUTORS if you are a new contributor.
• Add a ChangeLog entry describing what your PR does.
• If it's a new feature or an important bug fix, add a What's New entry in
  doc/whatsnew/<current release.rst>.
• Write a good description on what the PR does.

Description

Fix for false-positives described in #4630, when an dict index lookup has been reassigned.

dict index lookup after the reassignment are necessary

example:

d = {1: 1}
for k, v in d.items():
  d[k] = 10
  assert d[k] == v, (d[k], v)

output:

Traceback (most recent call last):
  File "<stdin>", line 3, in <module>
AssertionError: (10, 1)

Therefore, using d[k] after reassignment should be ignored

This is implemented by returning after encountering an astroid.AugAssign or astroid.Assign and ignore
nodes occurring after this.

Type of Changes

	Type
✓	🐛 Bug fix

Related Issue

Closes #4630

[coveralls]

Coverage remained the same at 92.038% when pulling 6e6c3a3 on yushao2:fix--false-positive-4630 into 472f25e on PyCQA:main.

[cdce8p]

Thanks for taking the time to look at this issue! I left a few comments, mostly minor stuff.

[yushao2]

@Pierre-Sassoulas seems like assigning 0 to a var makes it a constant, and naming convention is to be UPPERCASE.

I assigned an empty list to it instead, and changed += to .append.

Comment taken into account

[Pierre-Sassoulas]

seems like assigning 0 to a var makes it a constant, and naming convention is to be UPPERCASE. I assigned an empty list to it instead, and changed += to .append.

Oups, I did not see that, I disabled the invalid-name and force pushed. Sorry !

[yushao2]

seems like assigning 0 to a var makes it a constant, and naming convention is to be UPPERCASE. I assigned an empty list to it instead, and changed += to .append.

Oups, I did not see that, I disabled the invalid-name and force pushed. Sorry !

that's fine! i think both ways work 😆 thanks!