Fix similarity checker fails with ignore-signatures option enabled on function with docstring-only body
#4649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And fix tests/checkers/unittest_similar.py that required to have some
Pierre-Sassoulas
added
Blocker 🙅
Pierre-Sassoulas
changed the title
similarity checker fails with "ignore-signatures" option enabled on function with docstring-only body
Pierre-Sassoulas
changed the title
similarity checker fails with "ignore-signatures" option enabled on function with docstring-only bodysimilarity checker fails with ignore-signatures option enabled on function with docstring-only body
|
@hippo91 fwi, there will be a rebase to do, there will be some change to the similarity checker in 2.9.3 to fix a crash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a crash caused by the newly introduced ignore-signatures option for similarities checker fails for functions with an empty body with docstring only. Also include some refactor necessary so pre-commit works (trailing whitespace added in report).
Type of Changes
Related Issue
Closes #4648