Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unspecified-encoding checker #3826 #4753

Merged
merged 6 commits into from
Jul 28, 2021
Merged

Add unspecified-encoding checker #3826 #4753

merged 6 commits into from
Jul 28, 2021

Commits on Jul 28, 2021

  1. Add unspecified-encoding checker pylint-dev#3826 

    This adds an unspecified-encoding checker that adds a warning
whenever open() is called without an explicit encoding argument.
This closes pylint-dev#3826
    @DanielNoord
    DanielNoord committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    6527b39 View commit details
    Browse the repository at this point in the history

  2. Update tests to conform to unspecified-encoding 

    With addition of the unspecified-encoding checker calls of open()
need an encoding argument.
Where necessary this argument has been added, or the message has been
disabled.
This also includes small linting changes to a small number
of tests. Their test-data has been updated to reflect new line numbers.
    @DanielNoord
    DanielNoord committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    4779ee1 View commit details
    Browse the repository at this point in the history

  3. Update scripts to conform to unspecified-encoding 

    With addition of the unspecified-encoding checker calls of open()
need an encoding argument.
Where necessary this argument has been added.
    @DanielNoord
    DanielNoord committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    be30313 View commit details
    Browse the repository at this point in the history

  4. Update pylint to conform to unspecified-encoding 

    With addition of the unspecified-encoding checker calls of open()
need an encoding argument.
Where necessary this argument has been added.
    @DanielNoord
    DanielNoord committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    05b8ba5 View commit details
    Browse the repository at this point in the history

  5. Add min python version requirement to test

    @DanielNoord
    DanielNoord committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    fbe70d9 View commit details
    Browse the repository at this point in the history

  6. Parentheses aren't really necessary as and binds tighter than or 

    Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
    @Pierre-Sassoulas @cdce8p
    Pierre-Sassoulas and cdce8p committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    014c639 View commit details
    Browse the repository at this point in the history