Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives for invalid-all-format (#4711) #4829

Merged
merged 3 commits into from Aug 11, 2021
Merged

Fix false positives for invalid-all-format (#4711) #4829

merged 3 commits into from Aug 11, 2021

Conversation

kasium
Copy link
Contributor

@kasium kasium commented Aug 11, 2021

Type of Changes

Type
✓ 🐛 Bug fix

Description

invalid-all-format only considers lists and tuples and the direct form (e.g []) but ignores the builtin functions

Closes #4711

@Pierre-Sassoulas Pierre-Sassoulas added the False Positive 🦟 A message is emitted but nothing is wrong with the code label Aug 11, 2021
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.10.0 milestone Aug 11, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1120415945

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.622%
Totals Coverage Status
Change from base Build 1114083769: 0.0%
Covered Lines: 13282
Relevant Lines: 14340
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did pretty much everything for this bug :D Created the issue analyzed the problem, small diff for the fix, proper tests, that's a pretty great first contribution :) And it will be in 2.10.0 :)

@Pierre-Sassoulas Pierre-Sassoulas merged commit 47b483a into pylint-dev:main Aug 11, 2021
@kasium kasium deleted the issue-4711 branch August 11, 2021 14:43
@kasium
Copy link
Contributor Author

kasium commented Aug 11, 2021

Thanks a lot 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

False positive finding for E0605: Invalid format for __all__
3 participants
@kasium @coveralls @Pierre-Sassoulas