Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing with PyAnnotate to ./tests #4950

Merged
merged 21 commits into from Sep 4, 2021

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature, or an important bug fix, add a What's New entry in
    doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.
Type
🔨 Refactoring

Description

I thought I would try and see if I could use pyannote to do some typing for ./pytest.

I have split the changes into commits for each directory, sorry for the size of the PR I think this is about the limit of easy reviewing.

tests/test_func.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Sep 1, 2021

Pull Request Test Coverage Report for Build 1197891429

  • 5 of 5 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.0005%) to 93.098%

Totals Coverage Status
Change from base Build 1197864226: -0.0005%
Covered Lines: 13232
Relevant Lines: 14213

💛 - Coveralls

@DanielNoord DanielNoord marked this pull request as ready for review September 1, 2021 14:12
@DanielNoord
Copy link
Collaborator Author

For some reason mypy_extensions is not available on the windows test suite? Is this a known issue?

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, thank you. There's only this issue with the match change that needs to be addressed.

tests/pyreverse/test_diadefs.py Show resolved Hide resolved
tests/test_pragma_parser.py Outdated Show resolved Hide resolved
@DanielNoord
Copy link
Collaborator Author

I think this is now good to go!

@DanielNoord DanielNoord mentioned this pull request Sep 2, 2021
4 tasks
tests/test_func.py Outdated Show resolved Hide resolved
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.11.x milestone Sep 2, 2021
@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Sep 2, 2021
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is going to help tremendously for putting mypy in place. And it's giving me idea for astroid :)

pylint/lint/utils.py Show resolved Hide resolved
pylint/testutils/output_line.py Show resolved Hide resolved
tests/test_check_parallel.py Show resolved Hide resolved
tests/test_func.py Outdated Show resolved Hide resolved
tests/test_func.py Outdated Show resolved Hide resolved
tests/test_self.py Outdated Show resolved Hide resolved
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
@DanielNoord
Copy link
Collaborator Author

If I can find the time I would be willing to start this up for astroid as well. Although I would first finish doing all of PyAnnotate for the pylint codebase!

@Pierre-Sassoulas
Copy link
Member

If I can find the time I would be willing to start this up for astroid as well. Although I would first finish doing all of PyAnnotate for the pylint codebase!

I started something for astroid, pylint-dev/astroid#1163, but there will be a lot of work before being able to add mypy. pyannotate had some bug I had to manually fix the configuration json. We could discuss this in detail on the astroid's MR.

@DanielNoord
Copy link
Collaborator Author

Going to look at pylint-dev/astroid#1163 tomorrow.

Is there anything needed for this PR to be merged?

@Pierre-Sassoulas Pierre-Sassoulas merged commit 2500086 into pylint-dev:main Sep 4, 2021
@DanielNoord DanielNoord deleted the pyannotate-tests branch September 13, 2021 11:24
@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 2.11.x, 2.11.0 Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants