Upgrade astroid to 2.9.1

[Pierre-Sassoulas]

Type of Changes

	Type
✓	📜 Docs

Description

Closes #1470
Closes #3499
Closes #4302
Closes #4798
Closes #5081

[DanielNoord]

Potentially also fixes #1470?
I didn't look into it too much, but there is something about symlinking in there.

[Pierre-Sassoulas]

#1470 (comment) seems to indicate you're right, I'm going to see if I can add a regression test.

[coveralls]

Pull Request Test Coverage Report for Build 1640750960

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.01%) to 93.706%

---

Totals
Change from base Build 1640375350:	0.01%
Covered Lines:	14338
Relevant Lines:	15301

---

💛 - Coveralls

[Pierre-Sassoulas]

Sadly my regression test do not fail with astroid 2.9.0. Did you manage to reproduce #1470 @DanielNoord ? I can't with pylint 2.12.2 and astroid 2.9.0 myself.

[DanielNoord]

I didn't look into it too much. The issue seems too have a fairly straightforward reproducible example, that doesn't crash any longer?

[Pierre-Sassoulas]

that doesn't crash any longer?

Maybe... The issue is that my example / regression test does not crash with pylint 1.7.1 either. I guess having a symlink functional test isn't a bad thing though.

[DanielNoord]

Did we manage to make this regression test work? Or does it pass even with 2.9.0?

[Pierre-Sassoulas]

It pass even with 2.9.0, the symlink issue was actually happenning when the python installation was symlinked and not the analyzed code. But I think it's still a regression test for #1470 (the example is taken from here). Also a symlink functional tests can't hurt.

[DanielNoord]

Ah okay, so #1470 was resolved on 2.9.0 already?

[Pierre-Sassoulas]

Ah okay, so #1470 was resolved on 2.9.0 already?

I don't know if it's specifically in astroid 2.9.0 (or even in astroid, it could be pylint) but the issue was already fixed.

[DanielNoord]

Does git store symlinks? I think I used the unittest framework previously to create a symlink with os/sys. Other than that, this is good to go I think.

[Pierre-Sassoulas]

Does git store symlinks?

I think so, it's stored as the link to another file (I used the relative link for this reason). Maybe you can confirm by checking out this branch and opening the symlinked files ?

[Pierre-Sassoulas]

Nvm I think that ../module/symlinked_module.py would create a problem in github actions if it was not a symlink and a "normal" python file. (That would be invalid python)