Fix #5370: Emit redefined-outer-name when a nested except handler shadows an outer one
#5630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… handler shadows an outer one.
Pull Request Test Coverage Report for Build 1649860076
💛 - Coveralls |
Pierre-Sassoulas
requested changes
Jan 3, 2022
DanielNoord
approved these changes
Jan 3, 2022
There was a problem hiding this comment.
Thanks once again @jacobtylerwalls!
I feel like you have a New Years resolution of leaving no used-before-assignment and redefined-outer-name unfixed in 2022 😄
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com> Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
for more information, see https://pre-commit.ci
Pierre-Sassoulas
approved these changes
Jan 3, 2022
There was a problem hiding this comment.
Perfect, thanks ! (I guess this is also going to be an inspiration for fixing #4391)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Emit
redefined-outer-namewhen a nested except handler shadows (overwrites) the name used in an outer except handler.Implementation borrows from the
redefined-outer-nameimplementation for if branches.Closes #5370, Closes #4434