Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document a better release process #5858

Merged
merged 3 commits into from
Mar 24, 2022
Merged

Conversation

Pierre-Sassoulas
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas commented Mar 3, 2022

Type of Changes

Type
✨ New feature
🔨 Refactoring
📜 Docs

Description

Follow-up to #5877. This document the new git flow, based on review for pylint-dev/astroid#1438

Closes #4701

@Pierre-Sassoulas Pierre-Sassoulas added Documentation 📗 Maintenance Discussion or action around maintaining pylint or the dev workflow labels Mar 3, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.13.0 milestone Mar 3, 2022
@DanielNoord
Copy link
Collaborator

Haven't looked yet but two shower thoughts:

  1. We should probably split the Copyright change into its own PR and commit, that's not really part of the release process
  2. Not sure if you thought about this, but: we should probably remove the requirement that allows the dev version of astroid from the commit that is made into a release. That way user's will get warned when they install dev astroid + stable pylint. Process would be something like: 1. Update version and requirements to remove dev marker, 2. Update version and requirements to add dev marker.

@DanielNoord DanielNoord self-requested a review March 3, 2022 17:51
@Pierre-Sassoulas
Copy link
Member Author

We should probably split the Copyright change into its own PR and commit, that's not really part of the release process

Yes there is 3 different things here, I've been lazy :) I'm going to open other PR.

@Pierre-Sassoulas Pierre-Sassoulas added the Blocked 🚧 Blocked by a particular issue label Mar 4, 2022
@Pierre-Sassoulas
Copy link
Member Author

Blocked because we're going to merge the PR in astroid first and do the same change here after that.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1950576288

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.005%

Totals Coverage Status
Change from base Build 1948147488: 0.0%
Covered Lines: 14944
Relevant Lines: 15897

💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas removed the Blocked 🚧 Blocked by a particular issue label Mar 12, 2022
@DanielNoord
Copy link
Collaborator

@Pierre-Sassoulas To make this a little easier, shall we just copy the one from astroid? I don't think there is that much that is specific to astroid right?

@Pierre-Sassoulas
Copy link
Member Author

Yes, I'm going to do that :) I'm doing #5877 first and catching up with other MR

@Pierre-Sassoulas
Copy link
Member Author

@DanielNoord this is the same process than in astroid with the following modification : aa51220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation 📗 Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document a better release process than the current one
3 participants