Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabling of ungrouped-imports #5903

Merged
merged 4 commits into from
Mar 12, 2022

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature, or an important bug fix, add a What's New entry in
    doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Type of Changes

Type
🐛 Bug fix

Description

Needed for a PR that stops using the deprecated cachedproperty decorator from astroid.

@DanielNoord DanielNoord added this to the 2.13.0 milestone Mar 12, 2022
@coveralls
Copy link

coveralls commented Mar 12, 2022

Pull Request Test Coverage Report for Build 1974038123

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.025%

Totals Coverage Status
Change from base Build 1974036227: 0.0%
Covered Lines: 15029
Relevant Lines: 15984

💛 - Coveralls

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jacobtylerwalls
Copy link
Member

Cool. So it looks like #2366 wasn't truly fixed, as the regression test added in #5063 didn't repro -- it just lacked the final line from the original report! Is it worth referencing the original issue in the changelog or not?

@DanielNoord
Copy link
Collaborator Author

@jacobtylerwalls I totally forgot I added that method. Anyway, I think that this solution is better (instead of using the method added in #5063). I think I did not fully look into ungrouped-imports when I did that issue and only focused on the message in the OP.

I could add the issue, but since it was "fixed" in 2.12 might be a bit weird. @Pierre-Sassoulas You decide 😄

@jacobtylerwalls
Copy link
Member

I could add the issue, but since it was "fixed" in 2.12 might be a bit weird.

There are several cases where we just say "refers to" or "refs #..." right? best of both worlds.

@Pierre-Sassoulas
Copy link
Member

I think we don't need to create issue when the problem is fixed (We can Refs #The PR so those wanting detail can find them).

@DanielNoord DanielNoord merged commit 5756fae into pylint-dev:main Mar 12, 2022
@DanielNoord DanielNoord deleted the ungrouped-imports branch March 12, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants