-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regression test for #5771 #5908
Add regression test for #5771 #5908
Conversation
argnames = list( | ||
itertools.chain(node.argnames(), [arg.name for arg in node.args.kwonlyargs]) | ||
) | ||
argnames = node.argnames() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed leveraging the changes in astroid to simplify this here: #5771 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty nice simplification !
Pull Request Test Coverage Report for Build 1975120334
π - Coveralls |
argnames = list( | ||
itertools.chain(node.argnames(), [arg.name for arg in node.args.kwonlyargs]) | ||
) | ||
argnames = node.argnames() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty nice simplification !
Type of Changes
Description
Closes #5771
Refs pylint-dev/astroid#1382
Pardon me if this shouldn't go in 2.13! I just noticed no regression test PR for it yet, even though it's already fixed. Feel free to bump the milestone.