Fix crash in unnecessary-list-index-lookup checker (#6049)
#6061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2067770457
💛 - Coveralls |
DanielNoord
approved these changes
Mar 30, 2022
tests/functional/u/unnecessary/unnecessary_list_index_lookup.py
Outdated
Show resolved
Hide resolved
DanielNoord
added
Needs backport
Pierre-Sassoulas
approved these changes
Mar 30, 2022
|
This checker is not released yet, it's only in 2.14. So I'll remove the backport labels. |
jacobtylerwalls
removed
the
Needs backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
This fixes a crash in the
unnecessary-list-index-lookupchecker where the value fromenumerate()is being destructured, and thus no variable name is available. There are conceivably some cases where we could still salvage a useful check here, but the possible benefit seems minor and the original motivation was to catch the simple cases, so I hope we can just ignore this case for now.Closes #6049