Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove set_config_directly #6123

Merged
merged 2 commits into from
Apr 2, 2022
Merged

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
🔨 Refactoring

Description

As discussed in #5511.

I still think that 2.14 is good enough. Especially since this is a test decorator and won't impact performance of a plugin directly.

@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Apr 2, 2022
@DanielNoord DanielNoord added this to the 2.14.0 milestone Apr 2, 2022
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we might need to check the TODO before releasing because it's easier to forget about that. Maybe upgrade the #5513 type list when we add todos ?

@DanielNoord
Copy link
Collaborator Author

Actually we might need to check the TODO before releasing because it's easier to forget about that. Maybe upgrade the #5513 type list when we add todos ?

Because of argparse I'll need to do a full review of all TODOs anyway. But I'll add that to the list!

@DanielNoord DanielNoord mentioned this pull request Apr 2, 2022
15 tasks
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2081540364

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 94.239%

Totals Coverage Status
Change from base Build 2081530317: 0.04%
Covered Lines: 15523
Relevant Lines: 16472

💛 - Coveralls

@DanielNoord DanielNoord merged commit 93a1e01 into pylint-dev:main Apr 2, 2022
@DanielNoord DanielNoord deleted the deprecate branch April 2, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants