Add test coverage for sibling except handlers #6165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
the
Maintenance
Pull Request Test Coverage Report for Build 2085486197
💛 - Coveralls |
|
I looked at this again: I think we could make things more consistent by removing the special case (see end of discussion on #4391), but that would make pylint a bit worse, since it's already kind of a problem that pylint is all-or-nothing per name in the variables checker (see #4795). I figure just merging this test would suffice for now. |
Pierre-Sassoulas
approved these changes
Apr 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
This adds coverage in case this block is removed without a replacement. (Marking as draft for now: I don't understand why it's needed, so I might try to replace it.)
https://github.com/PyCQA/pylint/blob/a93602d92edbf11885645866216d194324578acf/pylint/checkers/variables.py#L2362-L2366