WIP: Add regression test for #6094 #6402
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
added
the
Needs astroid update
Pierre-Sassoulas
force-pushed
the
issue-6094
branch
from
d43c5cd
to
2b1a2ba
Compare
Pierre-Sassoulas
previously approved these changes
May 2, 2022
|
Still needs an astroid 2.12 update though as it's an enhancement :-) |
2 tasks
jacobtylerwalls
changed the title
|
Waiting on Daniel's investigation in pylint-dev/astroid#1519 |
|
My bad. I should have written something about this. Turns out this is quite difficult to solve. The ObjectModel is used to resolve some methods but for some reasons it gets priority over many other sources in the mro. This is problematic as very often stuff like However, in other places for some reason we depend on going to ObjectModel directly instead of using the mro. I haven't really found a solution but looking at the failed test in that PR and debugging why it gets incorrectly ingerrred shows pretty clear what is going wrong there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #6094 (requires pylint-dev/astroid#1519)