Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive for undefined-loop-variable when a loop else raises or returns #6480

Merged
merged 2 commits into from
May 1, 2022
Merged

Fix false positive for undefined-loop-variable when a loop else raises or returns #6480

merged 2 commits into from
May 1, 2022

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
✓ 🐛 Bug fix

Description

Closes #5971

@jacobtylerwalls jacobtylerwalls added Bug 🪲 Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer False Positive 🦟 A message is emitted but nothing is wrong with the code labels May 1, 2022
@jacobtylerwalls jacobtylerwalls added this to the 2.13.8 milestone May 1, 2022
@jacobtylerwalls jacobtylerwalls changed the title Fix a false positive for undefined-loop-variable when a loop else raises or returns Fix false positive for undefined-loop-variable when a loop else raises or returns May 1, 2022
@coveralls
Copy link

coveralls commented May 1, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2253705886

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.0006%) to 95.147%
Files with Coverage Reduction New Missed Lines %
pylint/checkers/variables.py 1 96.65%
Totals Coverage Status
Change from base Build 2253701411: 0.0006%
Covered Lines: 15783
Relevant Lines: 16588
💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas merged commit dede647 into pylint-dev:main May 1, 2022
@jacobtylerwalls jacobtylerwalls deleted the for-else-return branch May 1, 2022 13:57
@Pierre-Sassoulas Pierre-Sassoulas added Backported and removed Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels May 2, 2022
Pierre-Sassoulas added a commit that referenced this pull request May 2, 2022
@jacobtylerwalls @Pierre-Sassoulas
Fix a false positive for undefined-loop-variable when a loop else r…
deff919 
…aises or returns (#6480)

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Pierre-Sassoulas added a commit that referenced this pull request May 2, 2022
@jacobtylerwalls @Pierre-Sassoulas
Fix a false positive for undefined-loop-variable when a loop else r…
135477a 
…aises or returns (#6480)

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
@jacobtylerwalls jacobtylerwalls mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Backported Bug 🪲 False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
2.13.8
Development

Successfully merging this pull request may close these issues.

(🐞) false error: undefined-loop-variable when for loop has terminating else branch
3 participants
@jacobtylerwalls @coveralls @Pierre-Sassoulas