Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore underscore as a local variable #6492

Merged
merged 2 commits into from May 3, 2022
Merged

Ignore underscore as a local variable #6492

merged 2 commits into from May 3, 2022

Conversation

ayoung19
Copy link
Contributor

@ayoung19 ayoung19 commented May 3, 2022 •
edited

Type of Changes

Type
🐛 Bug fix
✓ ✨ New feature
🔨 Refactoring
📜 Docs

Description

Closes #6488

@ayoung19 ayoung19 mentioned this pull request May 3, 2022
Closed
DanielNoord
DanielNoord requested changes May 3, 2022
View reviewed changes
Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ayoung19 for picking this up!

The change itself looks good to me. However, could you perhaps add a changelog entry? This should probably go both in doc/whatsnew/2.14 and ./Changelog.

@DanielNoord DanielNoord added the Enhancement ✨ Improvement to a component label May 3, 2022
@DanielNoord DanielNoord added this to the 2.14.0 milestone May 3, 2022
@coveralls
Copy link

coveralls commented May 3, 2022 •
edited

Pull Request Test Coverage Report for Build 2264703932

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 45 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.006%) to 95.173%
Files with Coverage Reduction New Missed Lines %
pylint/checkers/imports.py 6 94.42%
pylint/checkers/variables.py 17 96.61%
pylint/checkers/spelling.py 22 76.96%
Totals Coverage Status
Change from base Build 2259008088: 0.006%
Covered Lines: 15833
Relevant Lines: 16636
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straightforward fix, and the test is on point, great first contribution !

@ayoung19
Copy link
Contributor Author

ayoung19 commented May 3, 2022

Just added the entry, let me know if I need to be more descriptive!

@DanielNoord DanielNoord merged commit 6aa336f into pylint-dev:main May 3, 2022
@DanielNoord
Copy link
Collaborator

Thanks @ayoung19, that is perfect! Congratulations on becoming a pylint contributor 😄

@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request May 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
Enhancement ✨ Improvement to a component
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

too-many-locals should ignore underscore variable names
4 participants
@ayoung19 @coveralls @DanielNoord @Pierre-Sassoulas