Pass msg_store and node to FileState

[DanielNoord]

• Write a good description on what the PR does.
• If you used multiple emails or multiple names when contributing, add your mails
  and preferred name in script/.contributors_aliases.json

Type of Changes

	Type
✓	✨ New feature
✓	🔨 Refactoring

Description

Base change required for #6556.
Let's also make modname required. It's a bit strange that we create a FileState before even encountering a file in the __init__, but refactoring that is not part of my plan for now.

[Pierre-Sassoulas]

It looks like it broke the config functional tests (report not generated anymore ?). I agree with the refactoring and deprecation in general.

(I think self.file_state = FileState("BaseState", self.msgs_store) might be defined before we needs it so it's not Optional and so it's defined in the __init__ ? I agree it's strange to do it like this.)

[DanielNoord]

It looks like it broke the config functional tests (report not generated anymore ?). I agree with the refactoring and deprecation in general.

(I think self.file_state = FileState("BaseState", self.msgs_store) might be defined before we needs it so it's not Optional and so it's defined in the __init__ ? I agree it's strange to do it like this.)

I don't really know why this breaks 😓

I think it has something to do with the mocking we do in the tests. For some reason not passing self.msgs_store in self.file_state = FileState("BaseState", self.msgs_store) fixes it. That doesn't seem like it should actually break but is more indicative of inter-test dependency.

[coveralls]

Pull Request Test Coverage Report for Build 2293322404

• 21 of 21 (100.0%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.003%) to 95.345%

---

Totals
Change from base Build 2292561596:	0.003%
Covered Lines:	16016
Relevant Lines:	16798

---

💛 - Coveralls

[DanielNoord]

Finally pass all tests on all platforms 🎉

[Pierre-Sassoulas]

👍