Makes functional tests auto-update works even if the current output is wrong #6891
Conversation
Pierre-Sassoulas
added
the
Maintenance
Pierre-Sassoulas
force-pushed
the
functional-update-even-for-bogus-expected-output
branch
from
8f4b536
to
437acf5
Compare
Pull Request Test Coverage Report for Build 2486769284
💛 - Coveralls |
This comment has been minimized.
This comment has been minimized.
You're rebasing a branch with change in the functional expected output. You don't want to fix the merge conflict, you just want to regenerate with the update option. Right now the update option fail if the output contain |
|
Okay, but simply discarding the merge change also works right? With the new code we only raise an |
Sure, but it's more work, and the message telling us to use update is wrong.
The functional test will also fail and ask you to update because we return |
…ent output is wrong Previously if an exception was raised during parsing we re-raised an explanation. Most of the time I just want to regenerate the output from the current pylint's output. It's what the exception suggested but it's impossible to do as the error is also raised when updating, so you had to empty the file.
Pierre-Sassoulas
force-pushed
the
functional-update-even-for-bogus-expected-output
branch
from
437acf5
to
2d9688f
Compare
doc/whatsnew/2/2.15/index.rst
Outdated
| @@ -61,3 +61,8 @@ Internal changes | |||
| * ``pylint.testutils.primer`` is now a private API. | |||
|
|
|||
| Refs #6905 | |||
|
|
|||
| * Fixed an issue where it was impossible to regenerate functional tests output when they existing | |||
There was a problem hiding this comment.
| * Fixed an issue where it was impossible to regenerate functional tests output when they existing | |
| * Fixed an issue where it was impossible to regenerate functional tests output when the existing |
Pierre-Sassoulas
force-pushed
the
functional-update-even-for-bogus-expected-output
branch
from
2d9688f
to
597f6bf
Compare
| * Fixed an issue where it was impossible to update functional tests output when the existing | ||
| output was impossible to parse. Instead of raising an error we raise a warning message and | ||
| let the functional test fail with a default value. | ||
|
|
There was a problem hiding this comment.
?
This is the PR right?
There was a problem hiding this comment.
There is no issue.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
Pierre-Sassoulas
deleted the
functional-update-even-for-bogus-expected-output
branch
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 02998c4 |
Type of Changes
Description
Previously if an exception was raised during parsing we re-raised an explanation.
Most of the time I just want to regenerate the output from the current pylint's
output. It's what the exception suggested but it's impossible to do as the error
is also raised when updating, so you had to empty the file.