Fix #3299 false positives with names in string literal type annotations

pylint/checkers/variables.py

@@ -19,7 +19,7 @@
 from typing import TYPE_CHECKING, Any, NamedTuple
 
 import astroid
-from astroid import nodes
+from astroid import extract_node, nodes
 from astroid.typing import InferenceResult
 
 from pylint.checkers import BaseChecker, utils
@@ -2922,6 +2922,8 @@ def visit_const(self, node: nodes.Const) -> None:
         if not utils.is_node_in_type_annotation_context(node):
             return
         if not node.value.isidentifier():
+            annotation = extract_node(node.value)
+            self._store_type_annotation_node(annotation)
             return
 
         # Check if parent's or grandparent's first child is typing.Literal

tests/functional/u/unused/unused_name_in_string_literal_type_annotation.py

@@ -1,13 +1,23 @@
 """Test if pylint sees names inside string literal type annotations. #3299"""
 from argparse import ArgumentParser, Namespace
+import os
+from os import PathLike
 from pathlib import Path
-from typing import Set
+from typing import NoReturn, Set
 
 # unused-import shouldn't be emitted for Path
 example1: Set["Path"] = set()
 
-def example2(_: "ArgumentParser"):
-    """unused-import shouldn't be emitted for ArgumentParser"""
+def example2(_: "ArgumentParser") -> "NoReturn":
+    """unused-import shouldn't be emitted for ArgumentParser or NoReturn."""
+    while True:
+        pass
+
+def example3(_: "os.PathLike[str]") -> None:
+    """unused-import shouldn't be emitted for os."""
+
+def example4(_: "PathLike[str]") -> None:
+    """unused-import shouldn't be emitted for PathLike."""
 
 # pylint: disable=too-few-public-methods
 class Class:

tests/functional/u/unused/unused_name_in_string_literal_type_annotation_py39.py

@@ -0,0 +1,10 @@
+# pylint: disable=missing-docstring
+import graphlib
+from graphlib import TopologicalSorter
+
+def example(
+    sorter1: "graphlib.TopologicalSorter[int]",
+    sorter2: "TopologicalSorter[str]",
+) -> None:
+    """unused-import shouldn't be emitted for graphlib or TopologicalSorter."""
+    print(sorter1, sorter2)

tests/functional/u/unused/unused_name_in_string_literal_type_annotation_py39.rc

@@ -0,0 +1,2 @@
+[testoptions]
+min_pyver=3.9