Fix bug in detecting unused-variable when iterating on variable.
#7537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Pull Request Test Coverage Report for Build 3138788546
💛 - Coveralls |
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit fd26bf6 |
Pierre-Sassoulas
added
the
False Positive 🦟
Pierre-Sassoulas
approved these changes
Sep 28, 2022
There was a problem hiding this comment.
Very elegant fix, it looks almost too simple. 😄 Let's wait for a review by @jacobtylerwalls before merging.
jacobtylerwalls
approved these changes
Sep 28, 2022
jacobtylerwalls
added
the
Needs backport
orSolocate
pushed a commit
to orSolocate/pylint
that referenced
this pull request
Oct 1, 2022
Pierre-Sassoulas
added
Backported
and removed
Needs backport
Pierre-Sassoulas
pushed a commit
to Pierre-Sassoulas/pylint
that referenced
this pull request
Oct 9, 2022
Pierre-Sassoulas
pushed a commit
to Pierre-Sassoulas/pylint
that referenced
this pull request
Oct 10, 2022
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3044
Type of Changes
Description
unused-variableshould not be reported in the case when a previously defined variable is now being used to iterate with.Closes #3044