Fix deprecated-method false positive

[clavedeluna]

Type of Changes

	Type
✓	🐛 Bug fix

Description

Original PR that added this code https://github.com/PyCQA/pylint/pull/4619/files
it seems that the unit test that was added led the code, which is a good practice, except I believe the unit test itself was incorrect and confused the naming of deprecated_method. This wasn't a necessary change at all, and in fact led to a false positive.

Closes #5886

[coveralls]

Pull Request Test Coverage Report for Build 3498044805

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.0005%) to 95.413%

---

Totals
Change from base Build 3495970943:	-0.0005%
Covered Lines:	17389
Relevant Lines:	18225

---

💛 - Coveralls

[github-actions]

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 2703b2d

[jacobtylerwalls]

Thank you! Makes sense. Test fails without the fix. Original issue that motivated the other PR still works:

$ cat a.py
import threading

print(threading.currentThread())

$ pylint a
************* Module a
a.py:3:6: W4902: Using deprecated method currentThread() (deprecated-method)

------------------------------------------------------------------
Your code has been rated at 5.00/10 (previous run: 5.00/10, +0.00)

[Pierre-Sassoulas]

(kinda) blocked by #7800, I'd like to test the new workflow with this if possible.

[Pierre-Sassoulas]

👍

[jacobtylerwalls]

@clavedeluna This PR is emitting a warning in the test suite. Would you be available to take a look? See run.

  /opt/hostedtoolcache/Python/3.10.8/x64/lib/python3.10/contextlib.py:142: DeprecationWarning: The end_col_offset attribute of MessageTest(msg_id='deprecated-method', line=9, node=<Call l.9 at 0x7ff5adaa3b50>, args=('new_name',), confidence=Confidence(name='UNDEFINED', description='Warning without any associated confidence level.'), col_offset=0, end_line=9, end_col_offset=12) does not match the expected value in MessageTest(msg_id='deprecated-method', line=9, node=<Call l.9 at 0x7ff5adaa3b50>, args=('new_name',), confidence=Confidence(name='UNDEFINED', description='Warning without any associated confidence level.'), col_offset=0, end_line=9, end_col_offset=21). In pylint 3.0 correct end_col_offset attributes will be required for MessageTest.