[changelog] Create separate entries for reimported/shadowed-import #7903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Maintenance
This was referenced Dec 5, 2022
cdce8p
requested changes
Dec 5, 2022
doc/whatsnew/fragments/4836.newcheck
Outdated
| @@ -0,0 +1,3 @@ | |||
| Add a ``shadowed-import`` message for aliased imports. | |||
There was a problem hiding this comment.
The file name should probably be new_check
There was a problem hiding this comment.
I added a small check for this, the result is : doc/whatsnew/fragments/4836.newchekc should probably be named '4836.new_check' instead. or doc/whatsnew/fragments/4836.glofbzid must be named one of '4836.internal', '4836.removed_check', '4836.extension', '4836.bugfix', '4836.other', '4836.new_check', '4836.false_negative', '4836.false_positive' instead.
There was a problem hiding this comment.
Thanks! This will definitely help. It has been an issue for me a couple of times as well.
Pierre-Sassoulas
force-pushed
the
fix-doc-for-shadowed-imports
branch
2 times, most recently
from
3289012
to
cf9416a
Compare
Pull Request Test Coverage Report for Build 3622995218
💛 - Coveralls |
Pierre-Sassoulas
force-pushed
the
fix-doc-for-shadowed-imports
branch
from
cf9416a
to
c93d53f
Compare
Pierre-Sassoulas
force-pushed
the
fix-doc-for-shadowed-imports
branch
from
c93d53f
to
13ad92e
Compare
10 tasks
clavedeluna
approved these changes
Dec 5, 2022
cdce8p
approved these changes
Dec 5, 2022
doc/whatsnew/fragments/4836.newcheck
Outdated
| @@ -0,0 +1,3 @@ | |||
| Add a ``shadowed-import`` message for aliased imports. | |||
There was a problem hiding this comment.
Thanks! This will definitely help. It has been an issue for me a couple of times as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
See #7756 (comment)