Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FP for used-before-assignment with assignment expressions in containers #8253

Merged
merged 3 commits into from
Feb 11, 2023
Merged

Fix FP for used-before-assignment with assignment expressions in containers #8253

merged 3 commits into from
Feb 11, 2023

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
✓ 🐛 Bug fix

Description

Closes #8252

@codecov
Copy link

codecov bot commented Feb 10, 2023 •
edited

Codecov Report

Merging #8253 (4516d8c) into main (f9d796f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8253   +/-   ##
=======================================
  Coverage   95.46%   95.46%           
=======================================
  Files         177      177           
  Lines       18689    18698    +9     
=======================================
+ Hits        17841    17850    +9     
  Misses        848      848
Impacted Files Coverage Δ
pylint/checkers/variables.py 97.30% <100.00%> (+0.01%) ⬆️
pylint/pyreverse/main.py 93.87% <0.00%> (+0.54%) ⬆️

@github-actions

This comment has been minimized.

Sign in to view
@Pierre-Sassoulas Pierre-Sassoulas added False Positive 🦟 A message is emitted but nothing is wrong with the code C: used-before-assignment Issues related to 'used-before-assignment' check backport maintenance/2.16.x labels Feb 10, 2023
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.16.2 milestone Feb 10, 2023
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 4516d8c

@Pierre-Sassoulas Pierre-Sassoulas merged commit a0b28f9 into pylint-dev:main Feb 11, 2023
@github-actions github-actions bot mentioned this pull request Feb 11, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Feb 11, 2023
@jacobtylerwalls @github-actions
Fix FP for used-before-assignment with assignment expressions in cont…
2fc0a4e 
…ainers (#8253)

(cherry picked from commit a0b28f9)
Pierre-Sassoulas pushed a commit that referenced this pull request Feb 11, 2023
@github-actions @jacobtylerwalls
Fix FP for used-before-assignment with assignment expressions in cont…
c2cd7c6 
…ainers (#8253) (#8262)

(cherry picked from commit a0b28f9)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
@jacobtylerwalls jacobtylerwalls deleted the walrus-later branch February 11, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Backported C: used-before-assignment Issues related to 'used-before-assignment' check False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
2.16.2
Development

Successfully merging this pull request may close these issues.

used-before-assignment false positive for named expressions in a not-first position in container
2 participants
@jacobtylerwalls @Pierre-Sassoulas